Tank Icon Maker (update for 1.25.0.0)

[Aslain]

On 5/22/2024 at 8:20 AM, Maggz said:

For right now i have not gotten to that, i have been pretty busy with work and other projects. It requires a significant recode to do a check for fonts on imported projects. One i have not had time to get to yet. It is on my next updates to do list tho

 

If this is so complicated, maybe there is a simpler solution, like a log file that I can check after icons are generated in batch mode?

[Maggz]

That might be alil easier to create a logfile as an output text info I will look into that as well as the other. Either way the original program was coded to basically not handle any exceptions inside of its structure. Which is why either option requires additional and recode of code thats there. its one thing to update to current functions and another to add into the mix a ton of backend code. I am capable up doing the updates, but a recode might be beyond my limited ability. Not saying it is for sure, but it might be. The only reason i updated this project was because the original author seemingly abandoned it. The fixes i implemented were VERY easy to do. I will take the time to learn a bit more as honestly i am trying to anyhow, and this is a reasonable addition that would help me learn anyhow, so i will be attempting it once i have time, That being said if anyone does want to try and do anything else inside the program i have no issue with that. I would even collab with someone who knows more than i do on the github code.

[Aslain]

@Maggz

 

In 1.25.0.0

 

Error: Value cannot be null (zero).

Parameter name: stream

 

 

This occurs when I want to save the icons.

 

Fix: <GuiPackageName>gui-part1 gui-part2 gui-part3</GuiPackageName>

In Data\WotGameVersion-#0001.xml
In Data\WotGameVersion-#0408.xml

[Maggz]

I am currently at work so i will be tackling this tonight and rebuild a new version that currently works, this will be minus the font check fix that you do need added. Thats going to be part of a much larger code restructure.

[Maggz]

updated, still nothing major in the way of a font check for bulk builds, I will have to recode that entire section as it currently doesn't even try checking anything. Put acouple small things into a the save section tho that will maybe help me on that.

[kupjones]

I am getting this error which prevents the atlases from being built.    The XML is created but neither the .dds nor the .png is built.   That .ddl is there.    It looks like it is the same .dll from the previous version.

 

 

[kupjones]

Well, on a whim I went and grabbed the latest FreeImage -- and that error went away.   But then an error with nvtt popped up.   Replacing that ended with an

 

Not that I expected updated DLLs to fix anything, but what the heck.   BTW, the nvidia SDK includes an even newer version of FreeImage than what is available on freeimage.sourceforge.

[Maggz]

Well thats odd, i built that and tested it on mine and it built things fine. Let me look into this and see what might be causing this. i think there is an added option for a newer sdk that i might have added which you may not? let me look into this more. It feels like a missing dependancy

 

 

 

 

*********** OK i think you might be missing this

.NET Framework 3.5 SP1

 

This is a new dependancy which i had to add which will try and help me get this font issue resolved for building bulk files This should have asked you to update or install this package when you ran the program?? If it didnt here is a link to the framework

 

https://www.microsoft.com/en-us/download/details.aspx?id=22

 

This would have been something ALOT of games and mods had back in the day but have moved past needing this, however it has some backend i think i need in order to accomplish what Aslain is try to have work. I hope this resolves you issue.

 

*******Secondary Edit

There is also a possibility that when you were prompted about updating the lingo that you didnt understand and skipped that or didnt, which would also break the build process as the updated lingo links i made where to force the program into the newer code structure, which the old format gives warning or obsolete errors, meaning that somewhere in the future they will just not compile when i build this project, so i had to update it.

[kupjones]

Well, even after loading the updated .net framework, same error with the FreeImage64.dll  

 

BTW, I am not attempting to build the code from source -- simply using your distro as is but I was simply trying to see if updated .dll's would make a difference.    They did, in a way but resulted in that final "Object reference not set ...."

[Maggz]

Were you prompted to update Lingo? If not that could also be causing this issue, as functions were renamed internally, Basically all new code structure going forward requires functions names to start with a capitalized letter. I basically renamed all internal functions the same names but made them capital. This should have triggered for you ( it did for me upon opening the program) to update Lingo. If it did and you didnt allow it to update or someone blocked this. that could be a cause for this. However I will look deeper into this when i get home from work this evening and see if i can find the exception inside the program.

[Maggz]

i honestly can not get this to reproduce, I have loaded all defualt build sets and tested a build on them all. plus my 7 sets of icons i have used over the last 10 yrs. I can not reproduce this error that you have, Either you have something in your buildset that i dont have in any of the 15 sets of icons i cant draw, or you have something on your system thats conflicting. I have tested this on now 3 different computers and they all load this program fine and can build all the icon packs without errors. Could you please share with me your icon styles so that i can start there and try to figure out if this is the program or something that ive added to this that is conflicting with your computer? Also were you able to build this all on the other version provided by kthulo?

 

I am sorry you are having this issue, i want to resolve it, but i cant reproduce it.

[kupjones]

Bizarre -- this is a new Win11 buiild but I can try it on my old Win10 PC that I haven't wiped yet.  

 

Attached is a zip of the TIM folder in my /roamiing/TankIconMaker2 folder.

 

Here is a screen snip of the patterns that I built and am using -- kupjones - left, kupjones - right and kupjones - reversible.  

 

BTW, individual icon file builds work fine -- it is simply the atlas builds that error out.

 

TankIconMaker2.zip

[Maggz]

OK so just building the atlas under the bulk build menu is erroring out for you, i will work on figuring out why this has changed. I actually do not think ive touched that section yet. Maybe adding in the updated .NET framework is not compatible with that. Either way this now gives me a method of reproduction and trying to get it resolved. I will try and get something figured out soon. Or i will revert back to pre .net upgrade and just try and figure the other issue out another way. TY for feedback.

[kupjones]

5 hours ago, Maggz said:

OK so just building the atlas under the bulk build menu is erroring out for you, i will work on figuring out why this has changed. I actually do not think ive touched that section yet. Maybe adding in the updated .NET framework is not compatible with that. Either way this now gives me a method of reproduction and trying to get it resolved. I will try and get something figured out soon. Or i will revert back to pre .net upgrade and just try and figure the other issue out another way. TY for feedback.

Thank you!   Sorry for not being clear and sending you on a wild goose chase -- I should have first indicated which build was erroring out. 

[Maggz]

On 6/10/2024 at 8:59 PM, kupjones said:

Thank you!   Sorry for not being clear and sending you on a wild goose chase -- I should have first indicated which build was erroring out. 

Ok so i have been testing and testing on every single one of the built-ins and even your supplied icon template. And in all my tests i can not get the error or any error for that matter outside of the atlas height error. So can you test your build on your machine one time while making sure your atlas height and width are large enough to cover your icons. Basically what i built them all to is 4096 width and 5120 height. Test it with that atlas build height and see if you get a bulk save that does save. because i do. I am not sure why you keep seeing the machine code error as a reason, it should not be posting that to you. I am trying everything i can to reproduce this, but i can not get it to reproduce and so far you are the only person posting this to me. I am building and testing on a Windows 11 pro OS with all current updates and all build packages needed to build anything from VS 2019.

 

 

If anyone else can try to just build atlases in the bulk saves and reproduce the error he is getting i really would like to know how its being reproduced. I have tried on windows 11, 10, 8.1. Those are the only machines i have access to and they all work fine for me. 

 

Now for the testing i did, i built in bulk about 12 or so icon templates with icons/battleatlas/vehiclemarkeratlas. All of those icon build successfully once i made the atlas height larger than the original templates. The one drawback i have noticed is that no matter what changes i make to the programs code if you have stored templates i can not force the height to be larger on saved templates, this causes an error upon trying to build them unless you edit your template height to accomodate the new increased number of tanks. 

 

IE when your atlas was made each icon was x amount of pixels tall and x amount wide, and it was made for only say 600 tanks, each new patch adds a couple tanks so the actual size of what can fit into the atlas from 5 yrs ago doesnt work today. This should give you when you build in normal build mode an error saying cant make atlas increase height. However for whatever reason you are getting a really weird machine code error which doesnt corrospond to what i can see in any errors i can reproduce. Funny enough if i edit my atlas height to a smaller than can work and try to build it posts me an error in bulk build saying i need to increase the height. Your system hjowever is not. I can not explain why. I have built and rebuilt the executable and tried everything i can think of to reproduce your error message. I am kinda stumped.

[kupjones]

I should feel special then lol.   Seriously, I have run into the sizing issue that you mention in the past -- and adjusting the size of the images took care of that.

 

 I have to be honest -- my Windows development always dealt with statically linked libraries and have never dealt with dll's nor .NET applications.   I am mystified how the exe cannot find a dll that sits right in the same directory as the exe. 

 

So now, it gets weirder.  I tried running the code again -- I get the same error that it cannot load FreeImage64.dll -- but the atlas.png and atlas.xml are still saved.   And a quick inspection seems to indicate that they are correct though I havent tried loading them yet.    I know this isnt your code -- and the only way that I know how to find the problem is putting this through a debugger and then stepping through until the error pops up.   So -- I'm willing to setup a dev environment and try this but I need to know exactly how to create that dev environment.   I guess I am about to start learning yet another programming language LOL.

[Maggz]

This issue has kinda taxed my knowledge base as well, as honestly C# is not my main programing language. I am primarily a python and lua kinda person. Most of the corrections i have made to the program are from a mindset of just tweaking the already working functions. This issue however might be outside my scope. Its odd that it worked for you this time while the other times it had not? The issue of the freeimage64.dll here is kinda a wierd issue to see. Is your system 64 bit or 32 bit? Maybe i will need to try and provide a 32bit and 64 bit option? Again this has all been speculation on my part to this point.

[kupjones]

64bit Win11 -- but it seems the original programmer decided to rename the FreeImage dlls into a 32 and 64 version, since the distro is simply 'freeimage.dll' and one installs either the 32 or 64 version.  

 

Yeah, C# is not the language of choice for most -- certainly not I.   And it *kinda* works -- but it still throws that odd error message, which makes me wonder what the purpose of that library is if the atlas gets built anyway.   Truly bizarre -- maybe I'll pllink at it and see. 

 

Thanks!

[Maggz]

honestly i do not know what the issue is with your error, i can not reproduce it. Maybe the end of  the day this program needs to be redone into c++. Which might make things more doable in terms of working correctly, believe it or not the program itself does not handle alot of things, the dlls it couples with are responsible for most of it. This means that doing any real big changes seems to be reliiant on the dlls being rebuilt, which for the most part is not even internally coded in the program, its just added in as a required item.

[kupjones]

I was wondering -- to me it seems it just needs to read the game files that have the information then the UI that allows one to design one's own icons, then spit them back out again.   I use it to build my own icons that are then used by XVM, plus the reversibles that are referenced by the game (which I built into a loadable mod).   I assumed C# was used due to needing a windows interface - I dont do standalone UI's anymore (its all web) hence the assumption.

[Maggz]

ok so basically this program was built at a time when c# was used just due to simplicity sake, That being said all the DLL's this program requires are outside references, meaning they are not built by Visual studio, i have no access to modifying thier code base. i can simply include them as dependancies. These dependancies do a fair amount of the heavy lifting for this program. The dll's included in this program are responsible for basically everything functional that this program does, essensially the only thing inside this code is that it references the wot directory, reads the xml file which tells it where to look for icons to build. Then displays those icons inside its "preview" panel. The actual drawing of the icons inside that panel is handled by freeimage64.dll or 32 bit version basied upon whatever OS you have. Basically nothing aside from putting a place for the freeimage dll to post to is done by this program, this program also utilizes outside dlls for saving the icons, hence why i am trying to have a workaround to accomplish what aslain requests. It would be great if it had no dlls and handled all these items inside of the program, They do not. There is also limitation upon what and how the icons can be modified due to limitations of freeimage.dll It is as they say a closed loop. There is only so much functionality that this current iteration of tank icon make is capable of.

[KOPOBA_HA_KOB3AHAX]

 

 

On 6/6/2024 at 3:50 PM, kupjones said:

Well, even after loading the updated .net framework, same error with the FreeImage64.dll

  

 

 

 

looks like this annoying error is all about missing VC++ redist files

 

as mentioned on original tool's site requirements are

 

• .NET Framework 4.0 or higher
• VC++ 2013 Redistributable

 

 

So i installed VS++ redistributable and i see no longer this error.

DDS files were created and i got my favorite (pogs) icons back in game 🙂

 

P.S.: i'm now wondering how come original requirements are higher than updated fork's  as ".NET Framework 3.5 SP1" was mentioned above :")

Edited July 11, 2024 by KOPOBA_HA_KOB3AHAX

[kupjones]

18 hours ago, KOPOBA_HA_KOB3AHAX said:

 

 

 

looks like this annoying error is all about missing VC++ redist files

 

as mentioned on original tool's site requirements are

 

• .NET Framework 4.0 or higher
• VC++ 2013 Redistributable

 

 

So i installed VS++ redistributable and i see no longer this error.

DDS files were created and i got my favorite (pogs) icons back in game 🙂

 

P.S.: i'm now wondering how come original requirements are higher than updated fork's  as ".NET Framework 3.5 SP1" was mentioned above :")

Sheepishly -- I failed to read that original installation page (which i likely did years ago when I started running this tool).   Installing the VC++ redist packages did finally solve the failure to build the DDS files.   I was already running .NET 4.5, so it was really only those VS runtime packages that were the culprit.

 

Amazing -- I am constantly reminded to RTFM.   Thanks for the head knock LOL.

[Maggz]

WOW, so i thought you would have atleast had the original requirements that kinda threw me for a loop since i couldnt reproduce your issue, you just didnt have the original requirements, me adding in an older version was just trying to get some way to try and make a work around for Aslain's issue, however after alot of trial and error i dont know if i can even make that happen without a total recode. I have laxed off on that and have been busy with work recently. Glad this now works for you Kupjones

 

[KOPOBA_HA_KOB3AHAX]

Gad it helped :)

 

> Amazing -- I am constantly reminded to RTFM.
Story of my life for, like, last 30 years...
After all these years i started to follow this rule if i can't solve problem on my own in 15 first minutes. Usually it helps %)
Learned it a hard way :)

[kupjones]

On 7/12/2024 at 9:26 PM, Maggz said:

WOW, so i thought you would have atleast had the original requirements that kinda threw me for a loop since i couldnt reproduce your issue, you just didnt have the original requirements, me adding in an older version was just trying to get some way to try and make a work around for Aslain's issue, however after alot of trial and error i dont know if i can even make that happen without a total recode. I have laxed off on that and have been busy with work recently. Glad this now works for you Kupjones

 

Sorry for being late responding --- work took me away.   Yes, that was a wild goose chase and my fault really.   My expectation was that Win11 and applying the updated  libraries would work -- clearly they did not.   So I *thought* I had the requirements loaded and I thought I had re-applied these old libraries.   All I can guess at this point is they were somehow removed.    My apologoes

[Sambor]

Hello guys, after today's update I have a problem with the icons. The error says - Unable to place images in the atlas. Try reducing the size of the images or resizing the atlas...
I didn't change anything since last update: atlas settings - 4096 width & 5000 height and icons settings - 80 width & 26 height.
Everything works perfectly before the 1.26.0.1 update and now I don't know how to set it right.

[Aslain]

13 minutes ago, Sambor said:

Hello guys, after today's update I have a problem with the icons. The error says - Unable to place images in the atlas. Try reducing the size of the images or resizing the atlas...
I didn't change anything since last update: atlas settings - 4096 width & 5000 height and icons settings - 80 width & 26 height.
Everything works perfectly before the 1.26.0.1 update and now I don't know how to set it right.

Change the atlas width and height, I have 5120x4512

 

 

The reason is that they added WT event icons in the 1.26.0.1 update, which take up space in the atlas file, and your current atlas dimensions are too small to fit all the icons, that's why you have to make it larger.

[Sambor]

Now it works, thank you very much, next time I'll know what to do 🙂