RaJCeL

@RamboSushi Thanks for pinging me back to this topic. As for now and the year passed I haven't gone into that macros... Sorry for that 😞

I am busy in real life and modding topics.

But as I see you patiently waited and still need that I will prioritize investigation about that to upcoming weeks.
So in other words, if I manage to find correct way to do so, there is possibly it would be added on next major patch (1.15.0.0 or 1.14.1.0 - I don't know which comes next, but just to give you idea what I mean by major patch).

If I didn't, don't hesitate to summon me again to give the update and push me once again.

//Edit: I just saw first news about 1.14.1.0 first test, so it comes next 😉

One more comment from my side. Perhaps you know XVM. The biggest, the most known WoT mod. Written in cooperation with WG developers. The biggest community to test. Very skilled modders. Imagine what happens in your garage when XVM mod cannot settle connection to its server? ... Game is forcibly closed...

You friend programmer looks to be a junior or either didn't paid enough attention to read the whole error stack and stopped reading after first line, because the breaking error is not coming directly from the connection issues, but from another unexpected behavior with handling saving/reading mods files.

I have already secured my mods from many various and different sides from file system issues, but with recent update I see many people with file systems errors, so in system/game environment there is something new that started to break the mod in unexpected place that for many months and years were secured and working well. And if your friend has scripted anything professionally then he/she should know that putting your whole code into try/catch is not a professional solution. If new issue starts to occur then game/software gets a patch after its fix, right?

I agree that mod shouldn't hang game and game shouldn't hang the os. I am trying to fix all scenarios users come up to me (I remember that for one issue that wasn't affecting me and most of the users I spend months, if I remember well even more than year to fix it. In many places I have totally rewritten the mod, started from the scratch and analyse line after line. But sadly users that report, don't want to spend few hours to test a fix. I spend tons of hours to fix an issue for few users that mostly don't even wanted to test). The difference in software/game dev world and modding is usually that behind them stand a team of professional testers. Imagine that hobby mod makers cannot afford to have professional test team. I am testing myself, some modpack creators are testing themselves or their teams that as well are not professionals. From all of those people test from recent time I didn't get any issue reports. Only some users that reports and usually the fix is the advice I will give you below.

So in the meantime I will be investigating, please reinstall my session stats mod and ensure you run game with admin privileges (that reduce number of file system errors to minimum).

As said above "screenshot, and attach logs" please.
And I need a time to play and get some field modifications to test 😛

Hello,

Thanks for report.

Personally I was not experiencing such issues so far, but I didn't played after recent micropatch.

1. Can you set "debug": true, in "World of Tanks\mods\configs\yk-stats\config.json" and then send python.log after the issue occurs?

2. Are you running the game with admin rights?

Best regards,

RaJCeL

Is it possible you send me your config file: World of Tanks\mods\configs\yk-stats\config.json

And replays of those battles?

As I am the creator of the mod you are showing I can create optional function to log values.

Some questions to analyze:

- only team summary or all players data as well?

- what data schema to follow: battle ID, date time, ally wn8 overall sum, ally wn8 overall avg, ally wn8 battle sum, ally wn8 battle avg, enemy wn8 overall sum, enemy wn8 overall avg, enemy wn8 battle sum, enemy wn8 battle avg?

I am glad that you came to right conclusion that data shown in a player is WN8 about a player overall and per battle WN8. In the header you have sum and average for that values for all team members.

By "readout of the battles during the last 60 days or so..." you mean to create some king of logs where those players/teams data would be saved?

Hello,

I can provide a details about script mods, using libs for in game settings menu, using libs for ingame simple visualizations, using WG API for data. All depends on a scope and a level of details you are interested in.

Regards

Yes, in that case mods cannot properly log to python.log. It needs to be unlocked.

In logs there are no trace of any battle played. Please setup debug true in config, then start game and play. After you realize any results are missing, create logs and share.

As well if possible, try to give some details that could give a lead like: specific tank, regular platoon, dynamic platoon, different battle type (like assault or grand battle) or something else.

In order to let me fix the issue first I need to estimate where is the bug. If it would be possible for me to reproduce issue - I can start fixing. If not - not likely to fix in short term...

Just in case it happen again:
 

Please go to mods/configs/yk-stats/config.json and set "debug": true,

Then create logs just after you see results for just ended battle are missing.
Try to give some details that could give a lead like: specific tank, platoon, dynamic platoon or something.

No errors on python.log...
Please go to mods/configs/yk-stats/config.json and set "debug": true,

Then create logs just after you see results for just ended battle are missing.

Is there a chance that those missing battles were dynamic platoons from battle?

Is it something you can repeat? Or one time action on your end?

W dniu 14.04.2021 o 16:43, R1031 napisał:

It works one session fine, then another session misses results. I have had this using two other stats as well and on more than one PC over the last 6 months. I did a clean game install last game update and still have it lose stats.   I did notice while using YasenKrasen that after the battle ended there is a delay of  5~10 seconds longer  for the results to pop up.

Sounds very weird. With next big patch, next week, I will publish improved battle results handling for YK, so give it a try and report me back if issues persists.

Every idea, observation that can help me trace the issue is more than welcome 🙂

Hello,

I don't see anything suspicious in logs. Do you have any observation about kind of lost results?

Regards

You cannot change it on your own, because mod is only developed to show WN8. To show something different I need to script that part. Thats why I am asking to understand users needs.

14 godzin temu, LightAngels napisał:

 

I think you misunderstand what I meant.

 

In the picture, the color (on the left side) on each player tells how good they are (overall, currently by WN8) and the color on the right tells how good they did in this specific battle (also by WN8). 

You don't need to describe what this mod is doing as I am the author of this mod 😂

But still what will tell you specific battle WR for player, if for winning team it would be 100% and for loosing 0%. For overall I understand the concept.

I can add macro for overall WR, so you could manually add it in config as 3rd or the only bar if WN8 is pointless for you. Keep in mind that 3rd bar will make place for nickname smaller, so more nicks would get cut (columns are fixed size).

And in general there is no need to be so offensive to people that would like to help and understand the concept with getting more info from requester.

Whats the point to calculate battle WR?

No logs, nothing to analyze.

Przy takiej liczbie błędów to ja się nie dziwie że gra się wiesza.
Błąd z YK widzę dotyczący databaseID, a dokładniej z kodu taka operacja: BWPlayer().databaseID
Czyli wedle silnika gry obiekt gracza nie ma id z bazy danych. Zapewne błędy synchronizacji, bo potem widać dużo błędów dotyczących referencji, nonetypów i błędy żądania asynchronicznego cache gry. Przy takiej siece proponowałbym sprawdzenie spójności plików gry, a potem testowanie z mniejszymi zbiorami modów żeby ograniczyć i znaleźć kolejno każdy mod, który dokłada od siebie błędy.

Są dwie sytuacje, w których dmg może się różnić:

1. Spoza zasięgu widzenia (inni)
2. Dmg który jest zadawany w momencie dobijania. Czasem gra odpala metodę zmieniającą HP czołgu (wtedy jest liczone), a czasem nie (wtedy nie liczone) (Ty i inni)

Dzięki za logi. Nie ma w nich błędów skryptowych, więc możliwe, że w ferworze walki udaje Ci się wcisnąć jakąś kombinacje klawiszy kluczowych i flagi pokazywania/chowania wiadomości się rozjeżdżają.

Mam już przygotowany ulepszony mechanizm pokazywania/chowania elementów moich modów, który planuje opublikować zapewne przy kolejnym dużym paczu (wydaje mi się, że powinien być w grudniu).

Hello,

Since many months I have on my to do backlog a feature for my "In battle statistics" mod to calculate DMG rng in battle for all shots (counting only shots that makes sense ofc). When I finally find time to do so it would be just copy paste for last shot roll.

Best regards,

RaJCeL